Re: git-bisect working only from toplevel dir

From: Peter Baumann <waste.manager@gmx.de>
Date: Nov 23, 2011, 20:26 UTC
Message-ID: <20111123202643.GB6291@m62s10.vlinux.de>
In-Reply-To: <20111123192329.GA21630@sigill.intra.peff.net>

On Wed, Nov 23, 2011 at 02:23:29PM -0500, Jeff King wrote:

Show 25 quoted lines

> On Wed, Nov 23, 2011 at 11:09:29AM -0800, Junio C Hamano wrote:
> 
> > As to the approach, I suspect that it would be far better if it made
> > workable with cd_to_toplevel at the beginning, instead of saying
> > SUBDIRECTORY_OK.
> > 
> > After all, the current directory may disappear during the course of
> > bisection, upon checking out a revision that did not have the directory
> > you started your bisection from.
> 
> But from what directory would you expect:
> 
>   git bisect run make
> 
> to run from? If you use a GNU-ish layout with all of your code in
> "src/", then I can see it useful to do something like:
> 
>   cd src
>   git bisect run make
> 
> If we cd_to_toplevel, we can remember the prefix that we started from
> and cd to it before running the user's command, but there is no
> guarantee that it actually exists. Maybe that commit should be
> considered indeterminate then?
>

Why not simply fail the run with exit(-1)? If the directory doesn't exist in an older commit (which I think is not that common) git bisect should simply stop and let the user proceed.

And yes, I find the current behaviour to forbid running git bisect from a subdirectory slighly annoying and I'm glad somebody took a stab at it.

-Peter