Re: git-bisect working only from toplevel dir

From: Jeff King <peff@peff.net>
Date: Nov 23, 2011, 19:23 UTC
Message-ID: <20111123192329.GA21630@sigill.intra.peff.net>
In-Reply-To: <7vd3cibqqe.fsf@alter.siamese.dyndns.org>

On Wed, Nov 23, 2011 at 11:09:29AM -0800, Junio C Hamano wrote:

Show 7 quoted lines

> As to the approach, I suspect that it would be far better if it made
> workable with cd_to_toplevel at the beginning, instead of saying
> SUBDIRECTORY_OK.
> 
> After all, the current directory may disappear during the course of
> bisection, upon checking out a revision that did not have the directory
> you started your bisection from.

But from what directory would you expect:

  git bisect run make

to run from? If you use a GNU-ish layout with all of your code in "src/", then I can see it useful to do something like:

  cd src
  git bisect run make

If we cd_to_toplevel, we can remember the prefix that we started from and cd to it before running the user's command, but there is no guarantee that it actually exists. Maybe that commit should be considered indeterminate then?

I dunno. I haven't thought that hard about it. But I don't think it's quite as simple as just telling bisect it's OK to run from a subdir.

-Peff