Re: [PATCH 1/3] revert: rename --reset option to --quit
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Nov 21, 2011, 22:43 UTC
- Message-ID
- <20111121224353.GC19682@elie.hsd1.il.comcast.net>
- In-Reply-To
- <m3bos5m7ez.fsf@localhost.localdomain>
Jakub Narebski wrote:
> Actually from what I understand --reset / --quit has to have different > meaning than --abort.
Right. I'll send a strawman series that introduces a "cherry-pick --abort" option soon to clarify this.
[...]
> BTW. I think that '--clear' (or '--clear-state') would be a better name > for this option.
Could you explain why? When I run "git cherry-pick --clear", I'd expect that it removes some files. Problems:
(1) It's not clear to the novice _which_ files it will remove. Maybe
".rej" files or something? (2) That the sequencer state is stored in files is an implementation
detail.>> Other than that I think I agree with the reasoning (and I think I too had >> encountered the irritation with the "sequencer state").
Thanks for the quick feedback, both of you.