git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] apply: squash consecutive slashes with p_value > 0

From
RBRobie Basak <robie.basak@canonical.com>
Date
Nov 17, 2011, 18:57 UTC
Message-ID
<20111117185718.GE17472@mal.justgohome.co.uk>
In-Reply-To
<7vmxbumxls.fsf@alter.siamese.dyndns.org>
On Thu, Nov 17, 2011 at 10:07:27AM -0800, Junio C Hamano wrote:
> If that is the case, I would rather say we should even shoot for
> simpler. Just tell the patch generator not to include unneeded double
> slashes.

I don't have a choice about the patch generator. These are humans typing "diff -ur foo.orig/ foo/" which I think is reasonable.

IMHO, this is a bug in git-apply's -p behaviour. It's not so much about stripping double slashes; more about doing the -p split in the middle of the doubled slashes rather than the end. patch does the right thing.

Previous: Junio C Hamano
Message 5 of 5 in “apply: squash consecutive slashes with p_value > 0”
  1. apply: squash consecutive slashes with p_value > 0Robie Basak, Nov 16, 2011
  2. Junio C HamanoNov 16, 2011
  3. Robie BasakNov 17, 2011
  4. Junio C HamanoNov 17, 2011
  5. Robie BasakNov 17, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.