From: Robie Basak <robie.basak@canonical.com>
Date: Thu, 17 Nov 2011 18:57:19 GMT
Subject: Re: [PATCH] apply: squash consecutive slashes with p_value > 0
Message-ID: <20111117185718.GE17472@mal.justgohome.co.uk>
In-Reply-To: <7vmxbumxls.fsf@alter.siamese.dyndns.org>

On Thu, Nov 17, 2011 at 10:07:27AM -0800, Junio C Hamano wrote:
> If that is the case, I would rather say we should even shoot for
> simpler. Just tell the patch generator not to include unneeded double
> slashes.

I don't have a choice about the patch generator. These are humans typing
"diff -ur foo.orig/ foo/" which I think is reasonable.

IMHO, this is a bug in git-apply's -p behaviour. It's not so much about
stripping double slashes; more about doing the -p split in the middle of
the doubled slashes rather than the end. patch does the right thing.