git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 3/3] upload-archive: use start_command instead of fork

From
Jeff King <peff@peff.net>
Date
Nov 15, 2011, 10:28 UTC
Message-ID
<20111115102807.GA18649@sigill.intra.peff.net>
In-Reply-To
<201111151122.48378.trast@student.ethz.ch>
On Tue, Nov 15, 2011 at 11:22:48AM +0100, Thomas Rast wrote:
Show 18 quoted lines
> > Remove the NOT_MINGW-prereq for t5000, as git-archive --remote
> > now works.
> 
> I see valgrind failures bisecting to this commit, like so:
> 
> ==19125== Syscall param execve(argv[i]) points to unaddressable byte(s)
> ==19125==    at 0x5303CB7: execve (in /lib64/libc-2.11.3.so)
> ==19125==    by 0x53045A5: execvpe (in /lib64/libc-2.11.3.so)
> ==19125==    by 0x4B183C: execv_git_cmd (exec_cmd.c:137)
> ==19125==    by 0x4F305E: start_command (run-command.c:277)
> ==19125==    by 0x47F5C9: cmd_upload_archive (upload-archive.c:98)
> ==19125==    by 0x4051F4: run_builtin (git.c:308)
> ==19125==    by 0x40538F: handle_internal_command (git.c:466)
> ==19125==    by 0x405556: main (git.c:553)
> ==19125==  Address 0x7feffe7d0 is not stack'd, malloc'd or (recently) free'd
> 
> when running 'make valgrind' in current master.  Let me know if you
> need more information.

With which test, and on what OS? I couldn't replicate running t5000 on Linux.

-Peff
Previous: Thomas RastNext: Thomas Rast
Message 7 of 17 in “port upload-archive to Windows”
  1. 0/3 port upload-archive to WindowsErik Faye-Lund, Oct 24, 2011
  2. 1/3 mingw: move poll out of sys-folderErik Faye-Lund, Oct 24, 2011
  3. 2/3 compat/win32/poll.c: upgrade from upstreamErik Faye-Lund, Oct 24, 2011
  4. 3/3 upload-archive: use start_command instead of forkErik Faye-Lund, Oct 24, 2011
  5. Jeff KingOct 24, 2011
  6. Thomas RastNov 15, 2011
  7. Jeff KingNov 15, 2011
  8. Thomas RastNov 15, 2011
  9. Jeff KingNov 15, 2011
  10. Erik Faye-LundNov 15, 2011
  11. Jeff KingNov 15, 2011
  12. Junio C HamanoNov 15, 2011
  13. Jeff KingNov 15, 2011
  14. 1/2 upload-archive: drop extra argument to prepare_argvJeff King, Nov 15, 2011
  15. upload-archive: use argv_array for sent parametersJeff King, Nov 15, 2011
  16. Jeff KingNov 15, 2011
  17. Andreas SchwabNov 15, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.