From: Jeff King <peff@peff.net>
Date: Tue, 15 Nov 2011 10:28:08 GMT
Subject: Re: [PATCH v4 3/3] upload-archive: use start_command instead of fork
Message-ID: <20111115102807.GA18649@sigill.intra.peff.net>
In-Reply-To: <201111151122.48378.trast@student.ethz.ch>

On Tue, Nov 15, 2011 at 11:22:48AM +0100, Thomas Rast wrote:

> > Remove the NOT_MINGW-prereq for t5000, as git-archive --remote
> > now works.
> 
> I see valgrind failures bisecting to this commit, like so:
> 
> ==19125== Syscall param execve(argv[i]) points to unaddressable byte(s)
> ==19125==    at 0x5303CB7: execve (in /lib64/libc-2.11.3.so)
> ==19125==    by 0x53045A5: execvpe (in /lib64/libc-2.11.3.so)
> ==19125==    by 0x4B183C: execv_git_cmd (exec_cmd.c:137)
> ==19125==    by 0x4F305E: start_command (run-command.c:277)
> ==19125==    by 0x47F5C9: cmd_upload_archive (upload-archive.c:98)
> ==19125==    by 0x4051F4: run_builtin (git.c:308)
> ==19125==    by 0x40538F: handle_internal_command (git.c:466)
> ==19125==    by 0x405556: main (git.c:553)
> ==19125==  Address 0x7feffe7d0 is not stack'd, malloc'd or (recently) free'd
> 
> when running 'make valgrind' in current master.  Let me know if you
> need more information.

With which test, and on what OS? I couldn't replicate running
t5000 on Linux.

-Peff