[PATCH 02/14] http: turn off curl signals

From: Jeff King <peff@peff.net>
Date: Nov 10, 2011, 07:48 UTC
Message-ID: <20111110074803.GB27950@sigill.intra.peff.net>
In-Reply-To: <20111110074330.GA27925@sigill.intra.peff.net>

Curl sets and clears the handler for SIGALRM, which makes it incompatible with git's progress code. However, we can ask curl not to do this.

Signed-off-by: Jeff King <peff@peff.net>
---
I'm a little iffy on this one. If I understand correctly, depending on
the build and configuration, curl may not be able to timeout during DNS
lookups. But I'm not sure if it does, anyway, since we don't set any
timeouts.

An alternate plan would be to give the progress code a mode where it gets poked by curl every second or so (curl has a PROGRESSFUNCTION option for doing this).

 http.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/http.c b/http.c
index 95c2dfd..4f9e004 100644
--- a/http.c
+++ b/http.c
@@ -318,6 +318,8 @@ static int has_cert_password(void)
 	if (curl_http_proxy)
 		curl_easy_setopt(result, CURLOPT_PROXY, curl_http_proxy);
 
+	curl_easy_setopt(result, CURLOPT_NOSIGNAL, 1);
+
 	return result;
 }

-- 
1.7.7.2.7.g9f96f