git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] name-hash.c: always initialize dir_next pointer

From
Jeff King <peff@peff.net>
Date
Nov 1, 2011, 22:39 UTC
Message-ID
<20111101223949.GA15578@sigill.intra.peff.net>
In-Reply-To
<4EB070D2.4040709@kdbg.org>
On Tue, Nov 01, 2011 at 11:21:06PM +0100, Johannes Sixt wrote:
Show 10 quoted lines
> Test t2021-checkout-overwrite.sh reveals a segfault in 'git add' on a
> case-insensitive file system when git is compiled with XMALLOC_POISON
> defined. The reason is that 2548183b (fix phantom untracked files when
> core.ignorecase is set) added a new member dir_next to struct cache_entry,
> but forgot to initialize it in all cases.
> 
> Signed-off-by: Johannes Sixt <j6t@kdbg.org>
> ---
>  You can also insert git config core.ignorecase true before the first
>  test script in t2021 to see the segfault.
Yikes, thanks.
-Peff
Previous: Junio C Hamano
Message 3 of 3 in “name-hash.c: always initialize dir_next pointer”
  1. name-hash.c: always initialize dir_next pointerJohannes Sixt, Nov 1, 2011
  2. Junio C HamanoNov 1, 2011
  3. Jeff KingNov 1, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.