From: Jeff King Date: Tue, 01 Nov 2011 22:39:49 GMT Subject: Re: [PATCH] name-hash.c: always initialize dir_next pointer Message-ID: <20111101223949.GA15578@sigill.intra.peff.net> In-Reply-To: <4EB070D2.4040709@kdbg.org> On Tue, Nov 01, 2011 at 11:21:06PM +0100, Johannes Sixt wrote: > Test t2021-checkout-overwrite.sh reveals a segfault in 'git add' on a > case-insensitive file system when git is compiled with XMALLOC_POISON > defined. The reason is that 2548183b (fix phantom untracked files when > core.ignorecase is set) added a new member dir_next to struct cache_entry, > but forgot to initialize it in all cases. > > Signed-off-by: Johannes Sixt > --- > You can also insert git config core.ignorecase true before the first > test script in t2021 to see the segfault. Yikes, thanks. -Peff