git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/6] git-p4: handle utf16 filetype properly

From
Stefano Lattarini <stefano.lattarini@gmail.com>
Date
Oct 16, 2011, 14:59 UTC
Message-ID
<201110161659.22261.stefano.lattarini@gmail.com>
In-Reply-To
<20111016144435.GE22144@arf.padd.com>

Hi Pete, and thanks for taking my previous remarks into account. I have one more nit/question though ...

On Sunday 16 October 2011, Pete Wyckoff wrote:
Show 12 quoted lines
> diff --git a/t/t9802-git-p4-filetype.sh b/t/t9802-git-p4-filetype.sh
> new file mode 100755
> index 0000000..dff0e02
> --- /dev/null
> +++ b/t/t9802-git-p4-filetype.sh
> @@ -0,0 +1,108 @@
> +#!/bin/sh
> +
> + [SNIP]
> +
> +		printf "three\nline\ntext" >f-ascii &&
>

With this command, the `f-ascii' file won't be newline-terminated. Is this intended, or the result of an oversight? The same goes for further similar usages in the rest f the patch.

Regards,
  Stefano
Previous: Pete WyckoffNext: Pete Wyckoff
Message 5 of 12 in “git-p4 tests, filetypes, shell metacharacters”
  1. 0/6 git-p4 tests, filetypes, shell metacharactersPete Wyckoff, Oct 16, 2011
  2. 1/6 git-p4 tests: refactor and cleanupPete Wyckoff, Oct 16, 2011
  3. Pete WyckoffOct 16, 2011
  4. 2/6 git-p4: handle utf16 filetype properlyPete Wyckoff, Oct 16, 2011
  5. Stefano LattariniOct 16, 2011
  6. Pete WyckoffOct 16, 2011
  7. Junio C HamanoOct 16, 2011
  8. Pete WyckoffOct 16, 2011
  9. 3/6 git-p4: recognize all p4 filetypesPete Wyckoff, Oct 16, 2011
  10. 4/6 git-p4: stop ignoring apple filetypePete Wyckoff, Oct 16, 2011
  11. 5/6 git-p4: keyword flattening fixesPete Wyckoff, Oct 16, 2011
  12. 6/6 git-p4: handle files with shell metacharactersPete Wyckoff, Oct 16, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.