From: Stefano Lattarini <stefano.lattarini@gmail.com>
Date: Sun, 16 Oct 2011 14:59:21 GMT
Subject: Re: [PATCH 2/6] git-p4: handle utf16 filetype properly
Message-ID: <201110161659.22261.stefano.lattarini@gmail.com>
In-Reply-To: <20111016144435.GE22144@arf.padd.com>

Hi Pete, and thanks for taking my previous remarks into account.  I have
one more nit/question though ...

On Sunday 16 October 2011, Pete Wyckoff wrote:
> diff --git a/t/t9802-git-p4-filetype.sh b/t/t9802-git-p4-filetype.sh
> new file mode 100755
> index 0000000..dff0e02
> --- /dev/null
> +++ b/t/t9802-git-p4-filetype.sh
> @@ -0,0 +1,108 @@
> +#!/bin/sh
> +
> + [SNIP]
> +
> +		printf "three\nline\ntext" >f-ascii &&
>
With this command, the `f-ascii' file won't be newline-terminated.  Is
this intended, or the result of an oversight?  The same goes for further
similar usages in the rest f the patch.

Regards,
  Stefano