git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/3] fetch: honor the user-provided refspecs when pruning refs

From
Jeff King <peff@peff.net>
Date
Oct 7, 2011, 16:39 UTC
Message-ID
<20111007163936.GA5212@sigill.intra.peff.net>
In-Reply-To
<1318005433.4579.5.camel@centaur.lab.cmartin.tk>
On Fri, Oct 07, 2011 at 06:37:13PM +0200, Carlos Martín Nieto wrote:
> > I assume you mean s/tag/branch/ in the last line?
> 
> Yeah, maybe ref would be better?
Yeah, agreed.
> > Tests?
> 
> Good point.

It sounds like you already have a reproduction recipe for this, and for the --tags thing in the next commit.

> OK, so take a step back and figure out what we want the rules to be
> before we call get_stale_heads. It does sound like a more elegant
> approach. I was trying to disrupt the callers as little as possible, but
> then again, there's only two. Will change.

Yeah. Sometimes we try hard to make a minimal patch, because it makes it easier to review. At the same time, I think it's more important to make the code clean if it needs it. Especially when there aren't many callers to disrupt.

-Peff
Previous: Carlos Martín NietoNext: Carlos Martín Nieto
Message 12 of 15 in “Be more careful when prunning”
  1. 0/3 Be more careful when prunningCarlos Martín Nieto, Oct 6, 2011
  2. 1/3 fetch: free all the additional refspecsCarlos Martín Nieto, Oct 6, 2011
  3. 2/3 fetch: honor the user-provided refspecs when pruning refsCarlos Martín Nieto, Oct 6, 2011
  4. 3/3 fetch: treat --tags like refs/tags/*:refs/tags/* when pruningCarlos Martín Nieto, Oct 6, 2011
  5. Ben BoeckelOct 6, 2011
  6. Carlos Martín NietoOct 6, 2011
  7. 0/3 Be more careful when prunningCarlos Martín Nieto, Oct 6, 2011
  8. 1/3 fetch: free all the additional refspecsCarlos Martín Nieto, Oct 6, 2011
  9. 2/3 fetch: honor the user-provided refspecs when pruning refsCarlos Martín Nieto, Oct 6, 2011
  10. Jeff KingOct 7, 2011
  11. Carlos Martín NietoOct 7, 2011
  12. Jeff KingOct 7, 2011
  13. 3/3 fetch: treat --tags like refs/tags/*:refs/tags/* when pruningCarlos Martín Nieto, Oct 6, 2011
  14. Jeff KingOct 7, 2011
  15. Carlos Martín NietoOct 7, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.