git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 3/3] fetch: treat --tags like refs/tags/*:refs/tags/* when pruning

From
Carlos Martín Nieto <cmn@elego.de>
Date
Oct 6, 2011, 21:21 UTC
Message-ID
<1317936107-1230-4-git-send-email-cmn@elego.de>
In-Reply-To
<1317936107-1230-1-git-send-email-cmn@elego.de>

If --tags is specified, add that refspec to the list given to prune_refs so it knows to treat it as a filter on what refs to should consider for prunning. This way

    git fetch --prune --tags origin
only prunes tags and doesn't delete the branch refs.
Signed-off-by: Carlos Martín Nieto <cmn@elego.de>
---
 builtin/fetch.c |   11 ++++++++++-
 1 files changed, 10 insertions(+), 1 deletions(-)
diff --git a/builtin/fetch.c b/builtin/fetch.c
index b937d71..94b2bd3 100644
--- a/builtin/fetch.c
+++ b/builtin/fetch.c
@@ -699,8 +699,17 @@ static int do_fetch(struct transport *transport,
 		free_refs(ref_map);
 		return 1;
 	}
-	if (prune)
+	if (prune) {
+		/* If --tags was specified, we need to tell prune_refs
+		 * that we're filtering the refs from the remote */
+		if (tags == TAGS_SET) {
+			const char * tags_refspec = "refs/tags/*:refs/tags/*";
+			refs = xrealloc(refs, (ref_count + 1) * sizeof(struct refspec));
+			refs[ref_count] = *parse_fetch_refspec(1, &tags_refspec);
+			ref_count++;
+		}
 		prune_refs(transport, refs, ref_count, ref_map);
+	}
 	free_refs(ref_map);
 
 	/* if neither --no-tags nor --tags was specified, do automated tag
-- 
1.7.5.2.354.g349bf
Previous: Jeff KingNext: Jeff King
Message 13 of 15 in “Be more careful when prunning”
  1. 0/3 Be more careful when prunningCarlos Martín Nieto, Oct 6, 2011
  2. 1/3 fetch: free all the additional refspecsCarlos Martín Nieto, Oct 6, 2011
  3. 2/3 fetch: honor the user-provided refspecs when pruning refsCarlos Martín Nieto, Oct 6, 2011
  4. 3/3 fetch: treat --tags like refs/tags/*:refs/tags/* when pruningCarlos Martín Nieto, Oct 6, 2011
  5. Ben BoeckelOct 6, 2011
  6. Carlos Martín NietoOct 6, 2011
  7. 0/3 Be more careful when prunningCarlos Martín Nieto, Oct 6, 2011
  8. 1/3 fetch: free all the additional refspecsCarlos Martín Nieto, Oct 6, 2011
  9. 2/3 fetch: honor the user-provided refspecs when pruning refsCarlos Martín Nieto, Oct 6, 2011
  10. Jeff KingOct 7, 2011
  11. Carlos Martín NietoOct 7, 2011
  12. Jeff KingOct 7, 2011
  13. 3/3 fetch: treat --tags like refs/tags/*:refs/tags/* when pruningCarlos Martín Nieto, Oct 6, 2011
  14. Jeff KingOct 7, 2011
  15. Carlos Martín NietoOct 7, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.