Re: 6d4bb3833c3d2114d (fetch: verify we have everything we need before updating our ref) breaks fetch

From: Jeff King <peff@peff.net>
Date: Oct 1, 2011, 06:03 UTC
Message-ID: <20111001060353.GA25228@sigill.intra.peff.net>
In-Reply-To: <1317426849.4331.29.camel@centaur.lab.cmartin.tk>

On Sat, Oct 01, 2011 at 01:54:08AM +0200, Carlos Martín Nieto wrote:

Show 7 quoted lines

> > Have you tried
> > 
> >   $ ./git fetch git://repo.or.cz/git
> 
> But this would execute /usr/local/libexec/git-fetch, wouldn't it? That
> is precisely what I don't want to execute, because I changed some code
> in builtin/fetch.c that I want to test.

No, but only because fetch is a builtin. However, it still doesn't set up exec_path correctly, so your rev-list problem would not go away.

> I guess I'll have to either properly install git from 'next' or base my
> changed on 'maint'

Just use bin-wrappers/git. That's exactly what it's there for (and it's what the test scripts use to make sure we are testing what is compiled).

Your change isn't the problem; only your testing method.

-Peff