Re: 6d4bb3833c3d2114d (fetch: verify we have everything we need before updating our ref) breaks fetch

From: Carlos Martín Nieto <cmn@elego.de>
Date: Sep 30, 2011, 23:54 UTC
Message-ID: <1317426849.4331.29.camel@centaur.lab.cmartin.tk>
In-Reply-To: <m3y5x8o527.fsf@localhost.localdomain>

On Wed, 2011-09-28 at 12:12 -0700, Jakub Narebski wrote:

Show 17 quoted lines

> Carlos Martín Nieto <cmn@elego.de> writes:
> 
> > Hello,
> > 
> > Whilst trying to do some work related to fetch, I came across a
> > regression in the 'next' branch. Bisecting gave me this commit as
> > breaking point (and I tried with the parent and there it worked). When
> > doing 'git fetch', rev-list will complain about usage, and fetch will
> > say that we didn't receive enough, even though earlier versions of git
> > have no problems. This fails both on github and on git.or.cz and for git
> > and http transports:
> > 
> > $ ./git-fetch git://repo.or.cz/git
> 
> Have you tried
> 
>   $ ./git fetch git://repo.or.cz/git

But this would execute /usr/local/libexec/git-fetch, wouldn't it? That is precisely what I don't want to execute, because I changed some code in builtin/fetch.c that I want to test.

But yes, the problem was that the local git-fetch was trying to pass an option to rev-list that my older installed binary didn't understand. In this particular case I don't want to run the older git-fetch, but otherwise, that would work.

I guess I'll have to either properly install git from 'next' or base my changed on 'maint'

cmn