Re: [PATCH 1/2] git svn dcommit: new option --interactive.

From

EWEric Wong <normalperson@yhbt.net>

Date

Sep 6, 2011, 20:26 UTC

Message-ID

<20110906202601.GA11668@dcvr.yhbt.net>

In-Reply-To

<1315164113-26539-2-git-send-email-frederic.heitzmann@gmail.com>

Frédéric Heitzmann <frederic.heitzmann@gmail.com> wrote:

> Allow the user to check the patch set before it is commited to SNV. It is then
> possible to accept/discard one patch, accept all, or quit.
> 
> This interactive mode is similar with 'git send email' behaviour. However,
> 'git svn dcommit' returns as soon as one patch is discarded.
> 
> Part of the code was taken from git-send-email.perl

> Thanks-to: Eric Wong <normalperson@yhbt.net> for the initial idea.
> Signed-off-by: Frédéric Heitzmann <frederic.heitzmann@gmail.com>

I agree with this feature, a few comments inline.

>  I would have preferred not duplicating the code snippets taken from
>  git-send-email ('ask' function, Term related code, ...) but I preferred not
>  to spoil Git.pm with it.
>  Any comment on a better way to factor perl code would be appreciated.

>  Documentation/git-svn.txt |    8 +++++
>  git-svn.perl              |   71 ++++++++++++++++++++++++++++++++++++++++++++-
>  2 files changed, 78 insertions(+), 1 deletions(-)

Tests and feature should be the same patch

> +	return defined $default ? $default : undef
> +		unless defined $term->IN and defined fileno($term->IN) and
> +		       defined $term->OUT and defined fileno($term->OUT);

Things to make life easier for (mainly) C programmers:

* Use C-style "&&" and "||" for conditionals.  "and" and "or" are lower
  precedence and better used for control flow (see perlop(1) manpage).

* Also, use parentheses for defined(foo) to disambiguate multiple
  conditions/statements.

-- 
Eric Wong