git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/3] push: old receive-pack does not understand --quiet

From
Clemens Buchacher <drizzd@aon.at>
Date
Sep 6, 2011, 19:52 UTC
Message-ID
<20110906195203.GA30927@ecki>
In-Reply-To
<7vty8p8s8n.fsf@alter.siamese.dyndns.org>
On Tue, Sep 06, 2011 at 11:01:44AM -0700, Junio C Hamano wrote:
Show 16 quoted lines
> Clemens Buchacher <drizzd@aon.at> writes:
> 
> > Commit 90a6c7d4 (propagate --quiet to send-pack/receive-pack)
> > introduced the --quiet option to receive-pack and made send-pack
> > pass that option. Older versions of receive-pack do not recognize
> > the option, however, and terminate immediately.
> >
> > This change restores backwards compatibility by adding a 'quiet'
> > capability to receive-pack.
> 
> Wouldn't this mean that there is no point in adding --quiet command line
> option to the receive-pack command? IOW, shouldn't parts of 90a6c7d
> (propagate --quiet to send-pack/receive-pack, 2011-07-30) be reverted?
> 
> At this late stage in the release cycle, I would rather prefer to revert
> the whole commit and leave anything new for the next cycle.

Sure, we can do that. Only then 1.7.6.1 will be broken against all versions except 1.7.6.1 on the server side. Right now it is only broken against 1.7.6 and older versions.

But I am ok with it either way. I will have to check how much resolving needs to be done after the revert.

Clemens
Previous: Junio C HamanoNext: Tobias Ulmer
Message 15 of 17 in “[BUG] git push --quiet fails with older versions”
  1. Tobias UlmerSep 3, 2011
  2. Clemens BuchacherSep 3, 2011
  3. 1/3 tests for push --quietClemens Buchacher, Sep 3, 2011
  4. 2/3 fix push --quiet via httpClemens Buchacher, Sep 3, 2011
  5. 3/3 push: old receive-pack does not understand --quietClemens Buchacher, Sep 3, 2011
  6. Junio C HamanoSep 5, 2011
  7. Junio C HamanoSep 5, 2011
  8. Junio C HamanoSep 5, 2011
  9. Michael J GruberSep 5, 2011
  10. Michael J GruberSep 5, 2011
  11. t5541: avoid TAP test miscountingMichael J Gruber, Sep 5, 2011
  12. Junio C HamanoSep 5, 2011
  13. Michael J GruberSep 6, 2011
  14. Junio C HamanoSep 6, 2011
  15. Clemens BuchacherSep 6, 2011
  16. Tobias UlmerSep 4, 2011
  17. Junio C HamanoSep 4, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.