git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/3] fix push --quiet via http

From
Clemens Buchacher <drizzd@aon.at>
Date
Sep 3, 2011, 16:34 UTC
Message-ID
<1315067656-2846-3-git-send-email-drizzd@aon.at>
In-Reply-To
<1315067656-2846-1-git-send-email-drizzd@aon.at>
A verbosity of 0 means quiet for remote helpers.
Signed-off-by: Clemens Buchacher <drizzd@aon.at>
---
 remote-curl.c        |    2 +-
 t/t5541-http-push.sh |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/remote-curl.c b/remote-curl.c
index 5798aa5..2341106 100644
--- a/remote-curl.c
+++ b/remote-curl.c
@@ -762,7 +762,7 @@ static int push_git(struct discovery *heads, int nr_spec, char **specs)
 		argv[argc++] = "--thin";
 	if (options.dry_run)
 		argv[argc++] = "--dry-run";
-	if (options.verbosity < 0)
+	if (options.verbosity == 0)
 		argv[argc++] = "--quiet";
 	else if (options.verbosity > 1)
 		argv[argc++] = "--verbose";
diff --git a/t/t5541-http-push.sh b/t/t5541-http-push.sh
index 0dcb8df..e756a08 100755
--- a/t/t5541-http-push.sh
+++ b/t/t5541-http-push.sh
@@ -155,7 +155,7 @@ test_expect_success 'push (chunked)' '
 	 test $HEAD = $(git rev-parse --verify HEAD))
 '
 
-test_expect_failure TTY 'quiet push' '
+test_expect_success TTY 'quiet push' '
 	cd "$ROOT_PATH"/test_repo_clone &&
 	test_commit quiet &&
 	test_terminal git push --quiet --no-progress 2>&1 | tee output &&
-- 
1.7.6.1
Previous: Clemens BuchacherNext: Clemens Buchacher
Message 4 of 17 in “[BUG] git push --quiet fails with older versions”
  1. Tobias UlmerSep 3, 2011
  2. Clemens BuchacherSep 3, 2011
  3. 1/3 tests for push --quietClemens Buchacher, Sep 3, 2011
  4. 2/3 fix push --quiet via httpClemens Buchacher, Sep 3, 2011
  5. 3/3 push: old receive-pack does not understand --quietClemens Buchacher, Sep 3, 2011
  6. Junio C HamanoSep 5, 2011
  7. Junio C HamanoSep 5, 2011
  8. Junio C HamanoSep 5, 2011
  9. Michael J GruberSep 5, 2011
  10. Michael J GruberSep 5, 2011
  11. t5541: avoid TAP test miscountingMichael J Gruber, Sep 5, 2011
  12. Junio C HamanoSep 5, 2011
  13. Michael J GruberSep 6, 2011
  14. Junio C HamanoSep 6, 2011
  15. Clemens BuchacherSep 6, 2011
  16. Tobias UlmerSep 4, 2011
  17. Junio C HamanoSep 4, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.