Re: Rebase & Trailing Whitespace

From: Clemens Buchacher <drizzd@aon.at>
Date: Sep 3, 2011, 20:18 UTC
Message-ID: <20110903201832.GB8362@ecki>
In-Reply-To: <20110902082851.GA17703@sigill.intra.peff.net>

On Fri, Sep 02, 2011 at 04:28:51AM -0400, Jeff King wrote:

Show 7 quoted lines

> 
> Yeah, there are a lot. Because of the potential disruption to patches in
> progress, though, we tend not to do big bulk updates of style changes.
> But it may be worth using the
> 
>   rm foo.c
>   git diff -R | git apply --whitespace=fix

I am looking at the output of:

 git diff --check 4b825 -- $(git ls-files '*.[ch]'|grep -v ^compat)

Most of those are false positives from multiline function argument lists, which are aligned with the first line. So the above command would break more than it would fix.

I don't care either way, but for future reference: Do we or do we not want indentation with spaces in this case?

Clemens