Re: Rebase & Trailing Whitespace

From: Jeff King <peff@peff.net>
Date: Sep 2, 2011, 08:28 UTC
Message-ID: <20110902082851.GA17703@sigill.intra.peff.net>
In-Reply-To: <4E6086AA.40806@drmicha.warpmail.net>

On Fri, Sep 02, 2011 at 09:32:58AM +0200, Michael J Gruber wrote:

Show 6 quoted lines

> > Thanks. By itself, I think many readers would ask "why would I want the
> > empty tree, so I threw in a few examples of use on the wiki, too.
> 
> Ugh. I mean: Thanks for the wiki entries, they're nice, but have you
> checked git.git for whitespace errors? Time for another war on
> whitespace? Many false positives, of course, but also true positives.

Yeah, there are a lot. Because of the potential disruption to patches in progress, though, we tend not to do big bulk updates of style changes. But it may be worth using the

  rm foo.c
  git diff -R | git apply --whitespace=fix

trick if you are going to be working on foo.c. And if there are a lot, you can "add -p" whatever fixes are appropriate for the area you're working in.

-Peff