Re: [PATCH 7/7] sequencer: Remove sequencer state after final commit

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Aug 14, 2011, 21:32 UTC
Message-ID: <20110814213200.GA6555@elie.gateway.2wire.net>
In-Reply-To: <7vei0nn1cn.fsf@alter.siamese.dyndns.org>

Hi Junio,

Junio C Hamano wrote:

> It still is unclear why "removing the sequencer state when no more insns
> are pending" is so necessary that the codebase needs to bend backwards to
> support that in the first place. What problem is d3f4628e really trying to
> solve?

I believe it is meant to support command sequences such as these:

1.
	git cherry-pick foo; # has conflicts
	... resolve conflicts and "git add" the resolved files ...
	git commit
	git cherry-pick bar

2.
	git cherry-pick foo bar; # has conflicts applying "bar"
	... resolve ...
	git commit
	git cherry-pick baz

Those were intuitive things to do before the sequencer existed, and if I understand correctly, d3f4628e was intended to support people and scripts (such as the test suite) that have these commands wired into their fingers.