[PATCH 1/7] revert: Free memory after get_message call
- From
Ramkumar Ramachandra <artagnon@gmail.com>
- Date
- Aug 14, 2011, 08:33 UTC
- Message-ID
- <1313310789-10216-2-git-send-email-artagnon@gmail.com>
- In-Reply-To
- <1313310789-10216-1-git-send-email-artagnon@gmail.com>
The format_todo function leaks memory because it forgets to call free_message after get_message. It is a potentially big leak, because fresh memory is allocated to store the commit message message for each commit. Fix this.
Reported-by: Jonathan Nieder <jrnieder@gmail.com> Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com> --- builtin/revert.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/builtin/revert.c b/builtin/revert.c index 8b452e8..8a35bfd 100644 --- a/builtin/revert.c +++ b/builtin/revert.c @@ -687,6 +687,7 @@ static int format_todo(struct strbuf *buf, struct commit_list *todo_list, if (get_message(cur->item, &msg)) return error(_("Cannot get commit message for %s"), sha1_abbrev); strbuf_addf(buf, "%s %s %s\n", action_str, sha1_abbrev, msg.subject); + free_message(&msg); } return 0; }
-- 1.7.6.351.gb35ac.dirty