Re: [BUG] git-am and git-submodule rely on $PATH to find perl
- From
Jeff King <peff@peff.net>
- Date
- Jul 22, 2011, 22:40 UTC
- Message-ID
- <20110722224017.GC19620@sigill.intra.peff.net>
- In-Reply-To
- <87fwm0inqr.fsf@write-only.cryp.to>
On Thu, Jul 21, 2011 at 12:35:56AM +0200, Peter Simons wrote:
> Both scripts run perl without any path, i.e. they don't use the > $PERL_PATH that was passed at build time.
This isn't exactly a bug. The rule we usually follow in git is that you can use "perl" in the PATH when you are doing simple awk-like things that any version of perl should do. But you must use PERL_PATH for #!-lines (because we can't do PATH lookup there), or for any non-trivial script.
That being said, I don't see any downside to using PERL_PATH. The Makefile tweaks would be pretty minimal. Want to work up a patch?
-Peff