threads / bug / 27868

[BUG] git-am and git-submodule rely on $PATH to find perl

Subject: [BUG] git-am and git-submodule rely on $PATH to find perl

## tl;dr

2 messages between Jul 20, 2011 and Jul 22, 2011.

replies: 1people: 2as markdown or json

Jeff King· Jul 22, 2011, 22:40 UTC · re: Peter Simons · lore

Re: [BUG] git-am and git-submodule rely on $PATH to find perl

On Thu, Jul 21, 2011 at 12:35:56AM +0200, Peter Simons wrote:
> Both scripts run perl without any path, i.e. they don't use the
> $PERL_PATH that was passed at build time.

This isn't exactly a bug. The rule we usually follow in git is that you can use "perl" in the PATH when you are doing simple awk-like things that any version of perl should do. But you must use PERL_PATH for #!-lines (because we can't do PATH lookup there), or for any non-trivial script.

That being said, I don't see any downside to using PERL_PATH. The Makefile tweaks would be pretty minimal. Want to work up a patch?

-Peff

← back to recent threads