Re: [PATCH] remote: allow "-t" with fetch mirrors

From: Jeff King <peff@peff.net>
Date: May 26, 2011, 17:31 UTC
Message-ID: <20110526173106.GA2608@sigill.intra.peff.net>
In-Reply-To: <7vk4ddxucf.fsf@alter.siamese.dyndns.org>

On Thu, May 26, 2011 at 10:08:48AM -0700, Junio C Hamano wrote:

Show 13 quoted lines

> > So 13fc2c1 was overly constrictive, and disallowed
> > reasonable specific-branch mirroring, like:
> >
> >   git remote add -t heads/foo -t heads/bar --mirror=fetch
> 
> I mildly disagree that it is "reasonable".  I would understand if it were
> something like this:
> 
>   git remote add -t heads/foo:heads/foo -t heads/bar:heads/bar
> 
> I am not saying selective copying is bad or useless.  It would be useful
> in some situations.  I am saying that is not a mirror, and reusing the
> same --mirror option for a different meaning may introduce confusion.

I think of it as "you are mirroring these specific refs to your repository" instead of "you are fetching these specific refs into remote tracking branches". But it is somewhat a matter of semantics.

I agree that allowing generalized refspecs via "-t" is a nicer solution in the long run. I am mostly trying to fix a regression in 13fc2c1 here; I guess the question is whether it is one worth fixing, or if people who want to do this in the meantime should just use "git config".

-Peff