git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Allow built-ins to also use -c var=val via alias

From
Jeff King <peff@peff.net>
Date
May 24, 2011, 21:57 UTC
Message-ID
<20110524215759.GA24298@sigill.intra.peff.net>
In-Reply-To
<20110524215202.GA22243@sigill.intra.peff.net>
On Tue, May 24, 2011 at 05:52:02PM -0400, Jeff King wrote:
Show 11 quoted lines
> On Tue, May 24, 2011 at 05:46:18PM -0400, Jeff King wrote:
> 
> > I think the right fix is simply to drop the "don't re-check the
> > environment after the first time" logic. It's not expensive to parse
> > compared to parsing config files, which is when we would do it. We can
> > just drop the existing list and reparse. You can even get rid of the
> > whole list and drop a bunch of code, I think, like:
> 
> Ack, wrong patch. That one doesn't even come close to compiling.
> 
> Try this (still not well tested, though).

Ugh, broken. That will teach me to just paste any random junk into my MUA. Hopefully you got the gist of what I was trying to say, but let me come up with a more readable and tested series.

-Peff
Previous: Jeff KingNext: Jeff King
Message 5 of 10 in “handle_options(): do not miscount how many arguments were used”
  1. handle_options(): do not miscount how many arguments were usedJunio C Hamano, May 24, 2011
  2. Allow built-ins to also use -c var=val via aliasJunio C Hamano, May 24, 2011
  3. Jeff KingMay 24, 2011
  4. Jeff KingMay 24, 2011
  5. Jeff KingMay 24, 2011
  6. Jeff KingMay 24, 2011
  7. 1/4 config: make environment parsing routines staticJeff King, May 24, 2011
  8. 2/4 git_config: don't peek at global config_parametersJeff King, May 24, 2011
  9. 3/4 config: always parse GIT_CONFIG_PARAMETERS during git_configJeff King, May 24, 2011
  10. 4/4 handle_options(): do not miscount how many arguments were usedJeff King, May 24, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.