From: Jeff King <peff@peff.net>
Date: Tue, 24 May 2011 21:57:59 GMT
Subject: Re: [PATCH] Allow built-ins to also use -c var=val via alias
Message-ID: <20110524215759.GA24298@sigill.intra.peff.net>
In-Reply-To: <20110524215202.GA22243@sigill.intra.peff.net>

On Tue, May 24, 2011 at 05:52:02PM -0400, Jeff King wrote:

> On Tue, May 24, 2011 at 05:46:18PM -0400, Jeff King wrote:
> 
> > I think the right fix is simply to drop the "don't re-check the
> > environment after the first time" logic. It's not expensive to parse
> > compared to parsing config files, which is when we would do it. We can
> > just drop the existing list and reparse. You can even get rid of the
> > whole list and drop a bunch of code, I think, like:
> 
> Ack, wrong patch. That one doesn't even come close to compiling.
> 
> Try this (still not well tested, though).

Ugh, broken. That will teach me to just paste any random junk into my
MUA. Hopefully you got the gist of what I was trying to say, but let me
come up with a more readable and tested series.

-Peff