git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/3] bisect: refactor sha1_array into a generic sha1 list

From
Jeff King <peff@peff.net>
Date
May 23, 2011, 21:53 UTC
Message-ID
<20110523215348.GA9706@sigill.intra.peff.net>
In-Reply-To
<7vy6212t23.fsf@alter.siamese.dyndns.org>
On Fri, May 20, 2011 at 10:14:12AM -0700, Junio C Hamano wrote:
Show 12 quoted lines
> Jeff King <peff@peff.net> writes:
> 
> > Yeah, they probably should both be unsigned, and the sorted flag should
> > be a bit-field (not that it saves any space here, but it makes its purpose
> > more clear).
> >
> > Junio, do you mind squashing this into patch 2/3?
> 
> I actually do ;-) If you grep for ALLOC_GROW and look at the structures
> they touch, nr/alloc pairs that are integers are the majority in our
> codebase, and I do not see much bikeshedding value in adding more unsigned
> ones to the mix.
OK, no complaint from me on that.
-Peff
Previous: Junio C HamanoNext: Jeff King
Message 7 of 11 in “avoid duplicate .have lines”
  1. 0/3 avoid duplicate .have linesJeff King, May 19, 2011
  2. 1/3 refactor refs_from_alternate_cb to allow passing extra dataJeff King, May 19, 2011
  3. 2/3 bisect: refactor sha1_array into a generic sha1 listJeff King, May 19, 2011
  4. Thiago FarinaMay 20, 2011
  5. Jeff KingMay 20, 2011
  6. Junio C HamanoMay 20, 2011
  7. Jeff KingMay 23, 2011
  8. 3/3 receive-pack: eliminate duplicate .have refsJeff King, May 19, 2011
  9. Junio C HamanoMay 20, 2011
  10. Jeff KingMay 20, 2011
  11. Junio C HamanoMay 20, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.