Re: [PATCH 2/3] bisect: refactor sha1_array into a generic sha1 list

From: Jeff King <peff@peff.net>
Date: May 20, 2011, 07:47 UTC
Message-ID: <20110520074714.GC3663@sigill.intra.peff.net>
In-Reply-To: <BANLkTikYih5hOU=_Q9N_b8VZ_KJeb8zePg@mail.gmail.com>

On Thu, May 19, 2011 at 09:17:42PM -0300, Thiago Farina wrote:

Show 7 quoted lines

> > +struct sha1_array {
> > +       unsigned char (*sha1)[20];
> > +       int nr;
> > +       int alloc;
> Would be worth to change from int to unsigned int? Maybe is fine as is
> though. It's that in some places we use unsigned int (string_list is
> one example).

Yeah, they probably should both be unsigned, and the sorted flag should be a bit-field (not that it saves any space here, but it makes its purpose more clear).

Junio, do you mind squashing this into patch 2/3?

diff --git a/sha1-array.h b/sha1-array.h
index 15d3b6b..b602303 100644
--- a/sha1-array.h
+++ b/sha1-array.h
@@ -3,9 +3,9 @@
 
 struct sha1_array {
 	unsigned char (*sha1)[20];
-	int nr;
-	int alloc;
-	int sorted;
+	unsigned nr;
+	unsigned alloc;
+	unsigned sorted:1;
 };
 
 #define SHA1_ARRAY_INIT { NULL, 0, 0, 0 }

-Peff