git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/4] basic priority queue implementation

From
Jeff King <peff@peff.net>
Date
May 20, 2011, 13:23 UTC
Message-ID
<20110520132344.GA30616@sigill.intra.peff.net>
In-Reply-To
<BANLkTinojbxq=y3f-GPJsL7OH2OAJfW6zw@mail.gmail.com>
On Fri, May 20, 2011 at 10:13:10AM -0300, Thiago Farina wrote:
Show 10 quoted lines
> > Speaking of naming, though, the real problem is that this data structure
> > should be called "pqueue" or something similar to indicate that it is
> > not a simple FIFO. Unfortunately, the short-and-sweet "pqueue" is taken
> > by openssl, which pollutes all over the global namespace.
> >
> Hum, yeah when I read the commit message I though about the name of
> the structure, but I didn't want to bother you with that. Probably you
> have considered the option of naming it 'priority_queue' too. Haven't
> you chose priority_queue, because you consider the name longer than
> necessary?

Exactly. Though unless somebody can come up with a practical case where using the priority queue speeds up some operation, I don't think it is worth applying anyway. So the naming question is somewhat academic. :)

-Peff
Previous: Thiago FarinaNext: Jeff King
Message 8 of 12 in “fetch: avoid repeated commits in mark_complete”
  1. fetch: avoid repeated commits in mark_completeJeff King, May 19, 2011
  2. 0/4 commit lists as priority queuesJeff King, May 19, 2011
  3. 1/4 Makefile: sort TEST_PROGRAMS listJeff King, May 19, 2011
  4. 2/4 basic priority queue implementationJeff King, May 19, 2011
  5. Thiago FarinaMay 20, 2011
  6. Jeff KingMay 20, 2011
  7. Thiago FarinaMay 20, 2011
  8. Jeff KingMay 20, 2011
  9. 3/4 commit: add infrastructure for priority queues of commitsJeff King, May 19, 2011
  10. 4/4 fetch-pack: use priority queue for mark_completeJeff King, May 19, 2011
  11. Junio C HamanoMay 20, 2011
  12. Junio C HamanoMay 20, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.