git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv1] git-p4: test harness directory handling tidyup

From
PWPete Wyckoff <pw@padd.com>
Date
May 12, 2011, 11:29 UTC
Message-ID
<20110512112937.GA3128@arf.padd.com>
In-Reply-To
<1305177299-27130-2-git-send-email-luke@diamand.org>
luke@diamand.org wrote on Thu, 12 May 2011 06:14 +0100:
Show 10 quoted lines
> The git-p4 test harness relied a lot on cd'ing to the target directory
> and then cd'ing back explicitly. That caused problems if the test failed
> partway through. i.e.
>   cd $git && stuff && cd "$TRASH_DIRECTORY"
> 
> Instead, use:
>   (cd $git && stuff)
> 
> Signed-off-by: Luke Diamand <luke@diamand.org>
> Suggested-by: Junio C Hamano <gitster@pobox.com>

I'm glad that Junio noticed and that you took the time to fix this. It was indeed a problem.

Acked-by: Pete Wyckoff <pw@padd.com>
Previous: Luke Diamand
Message 3 of 3 in “[PATCHv1] git-p4: test harness directory handling tidyup”
  1. Luke DiamandMay 12, 2011
  2. Luke DiamandMay 12, 2011
  3. Pete WyckoffMay 12, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.