From: Pete Wyckoff <pw@padd.com>
Date: Thu, 12 May 2011 11:29:37 GMT
Subject: Re: [PATCHv1] git-p4: test harness directory handling tidyup
Message-ID: <20110512112937.GA3128@arf.padd.com>
In-Reply-To: <1305177299-27130-2-git-send-email-luke@diamand.org>

luke@diamand.org wrote on Thu, 12 May 2011 06:14 +0100:
> The git-p4 test harness relied a lot on cd'ing to the target directory
> and then cd'ing back explicitly. That caused problems if the test failed
> partway through. i.e.
>   cd $git && stuff && cd "$TRASH_DIRECTORY"
> 
> Instead, use:
>   (cd $git && stuff)
> 
> Signed-off-by: Luke Diamand <luke@diamand.org>
> Suggested-by: Junio C Hamano <gitster@pobox.com>

I'm glad that Junio noticed and that you took the time to fix
this.  It was indeed a problem.

Acked-by: Pete Wyckoff <pw@padd.com>