git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [Annoyance] "git log .." thinks ".." is ambiguous

From
Jeff King <peff@peff.net>
Date
May 2, 2011, 20:42 UTC
Message-ID
<20110502204235.GA13584@sigill.intra.peff.net>
In-Reply-To
<7vhb9clu0n.fsf@alter.siamese.dyndns.org>
On Mon, May 02, 2011 at 01:36:24PM -0700, Junio C Hamano wrote:
Show 6 quoted lines
> And a matching "rev-parse" update should look like this.  I wonder if we
> could share some code between the two, though...
> 
>  Documentation/revisions.txt |    7 +++++++
>  builtin/rev-parse.c         |   16 ++++++++++++++--
>  2 files changed, 21 insertions(+), 2 deletions(-)

The doc update looks good to me. The duplication in rev-parse is pretty gross, but that is certainly not a problem you are introducing. It would be nice to clean it up, but I don't know how painful that would be. It seems like rev-parse should just be calling handle_revision_arg, but I'm sure there are some nasty corner cases. IOW, I am not volunteering. :)

-Peff
Previous: Junio C HamanoNext: Junio C Hamano
Message 5 of 19 in “[Annoyance] "git log .." thinks ".." is ambiguous”
  1. Junio C HamanoMay 2, 2011
  2. Jeff KingMay 2, 2011
  3. Jeff KingMay 2, 2011
  4. Junio C HamanoMay 2, 2011
  5. Jeff KingMay 2, 2011
  6. specifying ranges: we did not mean to make ".." an empty setJunio C Hamano, May 2, 2011
  7. Jeff KingMay 2, 2011
  8. Junio C HamanoMay 2, 2011
  9. Michael J GruberMay 3, 2011
  10. Junio C HamanoMay 3, 2011
  11. Michael J GruberMay 4, 2011
  12. Junio C HamanoMay 4, 2011
  13. Junio C HamanoMay 4, 2011
  14. Joshua JuranMay 3, 2011
  15. Michael J GruberMay 3, 2011
  16. Joshua JuranMay 3, 2011
  17. Michael J GruberMay 3, 2011
  18. Junio C HamanoMay 3, 2011
  19. John SzakmeisterMay 3, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.