From: Jeff King <peff@peff.net>
Date: Mon, 02 May 2011 20:42:35 GMT
Subject: Re: [Annoyance] "git log .." thinks ".." is ambiguous
Message-ID: <20110502204235.GA13584@sigill.intra.peff.net>
In-Reply-To: <7vhb9clu0n.fsf@alter.siamese.dyndns.org>

On Mon, May 02, 2011 at 01:36:24PM -0700, Junio C Hamano wrote:

> And a matching "rev-parse" update should look like this.  I wonder if we
> could share some code between the two, though...
> 
>  Documentation/revisions.txt |    7 +++++++
>  builtin/rev-parse.c         |   16 ++++++++++++++--
>  2 files changed, 21 insertions(+), 2 deletions(-)

The doc update looks good to me. The duplication in rev-parse is pretty
gross, but that is certainly not a problem you are introducing. It would
be nice to clean it up, but I don't know how painful that would be.  It
seems like rev-parse should just be calling handle_revision_arg, but I'm
sure there are some nasty corner cases. IOW, I am not volunteering. :)

-Peff