git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv2 00/11] gitweb: Change timezone in dates using JavaScript

From
Jakub Narebski <jnareb@gmail.com>
Date
Apr 19, 2011, 01:26 UTC
Message-ID
<201104190326.29922.jnareb@gmail.com>
In-Reply-To
<7vei4z6omh.fsf@alter.siamese.dyndns.org>
Junio C Hamano wrote:
Show 8 quoted lines
> This seems to break the build like this, by exposing a lack of dependency
> somewhere in the Makefile:
> 
>     ...
>     SUBDIR gitweb
> make: *** No rule to make target `gitweb/static/gitweb.js', needed by `git-instaweb'.  Stop.
> make: *** Waiting for unfinished jobs....
> 
Ah, thanks for report. and sorry for the bug.

This bug is caused by the fact that main Makefile doesn't know (as it should) that gitweb.js is now generated file.

The trouble is how to write rule for gitweb/static/gitweb.js, proxying it to gitweb/Makefile, without having to repeat its dependencies...

-- 
Jakub Narebski
Poland
Previous: Junio C HamanoNext: Jakub Narebski
Message 17 of 21 in “[PATCHv2 00/11] gitweb: Change timezone in dates using JavaScript”
  1. Jakub NarebskiApr 15, 2011
  2. 01/11 gitweb: Split JavaScript for maintability, combining on buildJakub Narebski, Apr 15, 2011
  3. 02/11 gitweb.js: Update and improve comments in JavaScript filesJakub Narebski, Apr 15, 2011
  4. 03/11 gitweb.js: Provide default values for padding in padLeftStr and padLeftJakub Narebski, Apr 15, 2011
  5. 04/11 gitweb.js: Extract and improve datetime handlingJakub Narebski, Apr 15, 2011
  6. 05/11 gitweb.js: Introduce gitweb/static/js/lib/cookies.jsJakub Narebski, Apr 15, 2011
  7. 06/11 gitweb.js: Provide getElementsByClassName method (if it not exists)Jakub Narebski, Apr 15, 2011
  8. 07/11 gitweb: Refactor generating of long dates into format_timestamp_htmlJakub Narebski, Apr 15, 2011
  9. 08/11 gitweb: Unify the way long timestamp is displayedJakub Narebski, Apr 15, 2011
  10. 09/11 gitweb: JavaScript ability to adjust time based on timezoneJakub Narebski, Apr 15, 2011
  11. 10/11 gitweb.js: Add UI for selecting common timezone to display datesJakub Narebski, Apr 15, 2011
  12. Jakub NarebskiApr 15, 2011
  13. Jakub NarebskiApr 15, 2011
  14. 10/11 gitweb.js: Add UI for selecting common timezone to display datesJakub Narebski, Apr 15, 2011
  15. 11/11 gitweb: Make JavaScript ability to adjust timezones configurableJakub Narebski, Apr 15, 2011
  16. Junio C HamanoApr 19, 2011
  17. Jakub NarebskiApr 19, 2011
  18. Jakub NarebskiApr 19, 2011
  19. Junio C HamanoApr 19, 2011
  20. 12/11 Remove gitweb/gitweb.cgi and other legacy targets from main MakefileJakub Narebski, Apr 19, 2011
  21. 01/11 git-instaweb: Simplify build dependency on gitwebJakub Narebski, Apr 19, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.