git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCHv2 00/11] gitweb: Change timezone in dates using JavaScript

From
Jakub Narebski <jnareb@gmail.com>
Date
Apr 15, 2011, 14:43 UTC
Message-ID
<1302878645-458-1-git-send-email-jnareb@gmail.com>
This is second version of this series.  First version was sent as
  [PATCH 00/11] gitweb: Change timezone
  http://thread.gmane.org/gmane.comp.version-control.git/171212

The major issue left is that changing (selecting) timezone doesn't work on Chrome / Chromium, as reported by Kevin Cernekee. See patch 10/11 for more details.

NOTE that this time, in this version of series, the path-by-patch comparison with original J.H. patches is not provided. It would be re-added in the final version.

This is split version (with assorted cleanups) of J.H. patch adding JavaScript-base ability to change timezone in which dates are displayed.

  [PATCH 0/1] Gitweb: Change timezone
    [PATCH 1/1] gitweb: javascript ability to adjust time based on timezone
  Message-Id: <1300925335-3212-1-git-send-email-warthog9@eaglescrag.net>
  http://thread.gmane.org/gmane.comp.version-control.git/169384/focus=169881

Below there is copy of original J.H. announcement: JH> JH> This is just a javascript implementation of Kevin's localtime JH> feature. It's pretty straight forward, though date handling in JH> Javascript is, special (head bangingly so). JH> JH> This should be good to run on any browser, with the safe fallback JH> of UTC being the default output should Javascript not work / be JH> available.

Table of contents:
~~~~~~~~~~~~~~~~~~
* [PATCH 01/11] gitweb: Split JavaScript for maintability, combining on build
  [PATCH 02/11] gitweb.js: Update and improve comments in JavaScript files
  [PATCH 03/11] gitweb.js: Provide default values for padding in padLeftStr and padLeft
  [PATCH 04/11] gitweb.js: Extract and improve datetime handling
  [PATCH 05/11] gitweb.js: Introduce gitweb/static/js/lib/cookies.js
  [PATCH 06/11] gitweb.js: Provide getElementsByClassName method (if it not exists)
  [PATCH 07/11] gitweb: Refactor generating of long dates into format_timestamp_html
  [PATCH 08/11] gitweb: Unify the way long timestamp is displayed
  Unchanged from previous version of this series.
* [PATCH 09/11] gitweb: JavaScript ability to adjust time based on timezone
  
  Cosmetic changes compared to previous version of this patch.
* [PATCHv2/RFC 10/11] gitweb.js: Add UI for selecting common timezone to display dates
  [PATCHv2/RFC 11/11] gitweb: Make JavaScript ability to adjust timezones configurable
  The main part.  The major part of changes is fixing noted issues,
  and bugs reported by Kevin Cernekee in response to v1 of series.
  The first patch of two, 10/11, includes additionally some
  refactorings that should make code cleaner and easier to follow
  (reducing size of functions).
  This is the same or nearly the same version of those two patches as
  sent to git mailing list as:
    http://thread.gmane.org/gmane.comp.version-control.git/171212/focus=171389
Shortlog:
~~~~~~~~~
Jakub Narebski (9):
  gitweb: Split JavaScript for maintability, combining on build
  gitweb.js: Update and improve comments in JavaScript files
  gitweb.js: Provide default values for padding in padLeftStr and padLeft
  gitweb.js: Extract and improve datetime handling
  gitweb.js: Introduce gitweb/static/js/lib/cookies.js
  gitweb.js: Provide getElementsByClassName method (if it not exists)
  gitweb: Refactor generating of long dates into format_timestamp_html
  gitweb: Unify the way long timestamp is displayed
  gitweb: Make JavaScript ability to adjust timezones configurable
John 'Warthog9' Hawley (2):
  gitweb: JavaScript ability to adjust time based on timezone
  gitweb.js: Add UI for selecting common timezone to display dates
Diffstat:
~~~~~~~~~
 .gitignore                                         |    1 +
 gitweb/Makefile                                    |   19 +-
 gitweb/gitweb.perl                                 |   76 +++--
 gitweb/static/gitweb.css                           |   33 ++
 gitweb/static/js/README                            |   20 ++
 gitweb/static/js/adjust-timezone.js                |  330 ++++++++++++++++++++
 .../static/{gitweb.js => js/blame_incremental.js}  |  228 +-------------
 gitweb/static/js/javascript-detection.js           |   43 +++
 gitweb/static/js/lib/common-lib.js                 |  224 +++++++++++++
 gitweb/static/js/lib/cookies.js                    |  114 +++++++
 gitweb/static/js/lib/datetime.js                   |  176 +++++++++++
 11 files changed, 1023 insertions(+), 241 deletions(-)
 create mode 100644 gitweb/static/js/README
 create mode 100644 gitweb/static/js/adjust-timezone.js
 rename gitweb/static/{gitweb.js => js/blame_incremental.js} (74%)
 create mode 100644 gitweb/static/js/javascript-detection.js
 create mode 100644 gitweb/static/js/lib/common-lib.js
 create mode 100644 gitweb/static/js/lib/cookies.js
 create mode 100644 gitweb/static/js/lib/datetime.js
Dirstat:
~~~~~~~~
  40.1% gitweb/static/js/lib/
  32.7% gitweb/static/js/
  18.3% gitweb/static/
   8.7% gitweb/
-- 
1.7.3
Next: Jakub Narebski
Message 1 of 21 in “[PATCHv2 00/11] gitweb: Change timezone in dates using JavaScript”
  1. Jakub NarebskiApr 15, 2011
  2. 01/11 gitweb: Split JavaScript for maintability, combining on buildJakub Narebski, Apr 15, 2011
  3. 02/11 gitweb.js: Update and improve comments in JavaScript filesJakub Narebski, Apr 15, 2011
  4. 03/11 gitweb.js: Provide default values for padding in padLeftStr and padLeftJakub Narebski, Apr 15, 2011
  5. 04/11 gitweb.js: Extract and improve datetime handlingJakub Narebski, Apr 15, 2011
  6. 05/11 gitweb.js: Introduce gitweb/static/js/lib/cookies.jsJakub Narebski, Apr 15, 2011
  7. 06/11 gitweb.js: Provide getElementsByClassName method (if it not exists)Jakub Narebski, Apr 15, 2011
  8. 07/11 gitweb: Refactor generating of long dates into format_timestamp_htmlJakub Narebski, Apr 15, 2011
  9. 08/11 gitweb: Unify the way long timestamp is displayedJakub Narebski, Apr 15, 2011
  10. 09/11 gitweb: JavaScript ability to adjust time based on timezoneJakub Narebski, Apr 15, 2011
  11. 10/11 gitweb.js: Add UI for selecting common timezone to display datesJakub Narebski, Apr 15, 2011
  12. Jakub NarebskiApr 15, 2011
  13. Jakub NarebskiApr 15, 2011
  14. 10/11 gitweb.js: Add UI for selecting common timezone to display datesJakub Narebski, Apr 15, 2011
  15. 11/11 gitweb: Make JavaScript ability to adjust timezones configurableJakub Narebski, Apr 15, 2011
  16. Junio C HamanoApr 19, 2011
  17. Jakub NarebskiApr 19, 2011
  18. Jakub NarebskiApr 19, 2011
  19. Junio C HamanoApr 19, 2011
  20. 12/11 Remove gitweb/gitweb.cgi and other legacy targets from main MakefileJakub Narebski, Apr 19, 2011
  21. 01/11 git-instaweb: Simplify build dependency on gitwebJakub Narebski, Apr 19, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.