Re: What's cooking in git.git (Mar 2011, #06; Thu, 31)
- From
Jeff King <peff@peff.net>
- Date
- Apr 1, 2011, 17:06 UTC
- Message-ID
- <20110401170610.GA23014@sigill.intra.peff.net>
- In-Reply-To
- <7vbp0phpmx.fsf@alter.siamese.dyndns.org>
On Fri, Apr 01, 2011 at 10:01:42AM -0700, Junio C Hamano wrote:
Show 14 quoted lines
> >> * jc/add-u-migration (2011-03-22) 3 commits > >> - add: make "add -u/-A" update full tree without pathspec (step 3) > >> - add: make "add -u/-A" update full tree without pathspec (step 2) > >> (merged to 'next' on 2011-03-31 at 962e058) > >> + add: make "add -u/-A" update full tree without pathspec > [...] > > I have been meaning to look closer at this. Were you wanting to get the > > first stage of the transition into 1.7.5? > > I was tempted to but I think it would be far more pleasant if the first > step were to add the warning against "add -u" without pathspec that is ran > from a subdirectory to advise "if you meant 'from here', say '.', if you > meant 'everywhere', say ':/'---for now we pretend you said '.' to match > the traditional behaviour."
Yes, I think that is definitely the right first step.
Show 11 quoted lines
> It is adding even more confusion to add the "in this repository, 'add -u' > is tree-wide" configuration variable without giving people who need to > override that in unfamiliar repositories (read: scripts). > > Right now, we don't have a good advice to force the tree-wide behaviour > other than "cd $(git rev-parse --show-cdup)/. && git add -u", which is > quite a mouthful. > > We know how the magic "this pathspec is from the root" should work, and I > think we even saw "should look like this" patches, but haven't applied to > any branch so far yet.
That reasoning makes sense. Let's let the :/ patches develop and cook for post-1.7.5, then, and worry about it in the next cycle when we can build on top of them.
-Peff