git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/4] teach wait_or_whine a "quiet" mode

From
Johannes Sixt <j6t@kdbg.org>
Date
Mar 31, 2011, 20:56 UTC
Message-ID
<201103312256.39317.j6t@kdbg.org>
In-Reply-To
<20110331184342.GA16906@sigill.intra.peff.net>
On Donnerstag, 31. März 2011, Jeff King wrote:
Show 12 quoted lines
> The wait_or_whine function will complain to stderr in a few
> cases:
>
>   1. We fail to actually waitpid() correctly.
>
>   2. The child died of a signal.
>
>   3. The child returned exit code 127, indicating a missing
>      command to exec after forking.
>
> We already have a silent_exec_failure flag to silence (3).
> Let's convert that into a "quiet" flag to also silence (2).

I'm rather negative on controlling these two error reports with the same flag because...

> This shouldn't result in signal failure being silent for
> existing users of silent_exec_failure, since they already
> will need to be checking the return code and complaining for
> the case of a non-zero exit code.

This reasoning is not correct. Error reporting in the routines in run-command.c is structured such that callers have to check the return code, but they do not report errors themselves. Therefore, even if callers request silent_exec_failure, they will not do their own error reporting if there is some other failure.

-- Hannes
Previous: Jeff KingNext: Jeff King
Message 3 of 48 in “fix hang in git push when pack-objects fails”
  1. 0/4 fix hang in git push when pack-objects failsJeff King, Mar 31, 2011
  2. 1/4 teach wait_or_whine a "quiet" modeJeff King, Mar 31, 2011
  3. Johannes SixtMar 31, 2011
  4. Jeff KingApr 1, 2011
  5. 2/4 finish_async: be quiet when waiting for async processJeff King, Mar 31, 2011
  6. 3/4 run-command: allow aborting async code prematurelyJeff King, Mar 31, 2011
  7. Erik Faye-LundApr 1, 2011
  8. Jeff KingApr 1, 2011
  9. 4/4 send-pack: abort sideband demuxer on pack-objects errorJeff King, Mar 31, 2011
  10. Johannes SixtApr 13, 2011
  11. Jeff KingApr 14, 2011
  12. Johannes SixtApr 14, 2011
  13. Jeff KingApr 14, 2011
  14. Johannes SixtApr 14, 2011
  15. Jeff KingApr 14, 2011
  16. Johannes SixtApr 14, 2011
  17. Junio C HamanoApr 14, 2011
  18. 1/2 send-pack --stateless-rpc: properly close the outgoing channelJohannes Sixt, Apr 24, 2011
  19. 2/2 send-pack: avoid deadlock when pack-object dies earlyJohannes Sixt, Apr 24, 2011
  20. Jeff KingApr 25, 2011
  21. Johannes SixtApr 25, 2011
  22. Junio C HamanoApr 25, 2011
  23. send-pack: avoid deadlock when pack-object dies earlyJohannes Sixt, Apr 25, 2011
  24. Jeff KingApr 26, 2011
  25. Jeff KingApr 25, 2011
  26. 5/4 run-command: implement abort_async for pthreadsJeff King, Mar 31, 2011
  27. Erik Faye-LundApr 1, 2011
  28. Erik Faye-LundApr 1, 2011
  29. Johannes SixtApr 1, 2011
  30. Jeff KingApr 1, 2011
  31. Erik Faye-LundApr 1, 2011
  32. Erik Faye-LundApr 1, 2011
  33. Johannes SixtApr 1, 2011
  34. Erik Faye-LundApr 1, 2011
  35. Jeff KingApr 1, 2011
  36. Erik Faye-LundApr 1, 2011
  37. Jeff KingApr 1, 2011
  38. Jeff KingApr 1, 2011
  39. Erik Faye-LundApr 1, 2011
  40. Johannes SixtApr 1, 2011
  41. Erik Faye-LundApr 1, 2011
  42. Johannes SixtApr 1, 2011
  43. Erik Faye-LundApr 1, 2011
  44. Jeff KingApr 1, 2011
  45. Erik Faye-LundApr 2, 2011
  46. Jeff KingApr 1, 2011
  47. Johannes SixtMar 31, 2011
  48. Jeff KingApr 1, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.