Re: [RFC/PATCH] commit notes workflow
- From
- Yann Dirson <dirson@bertin.fr>
- Date
- Mar 9, 2011, 08:13 UTC
- Message-ID
- <20110309091307.4b759b7e@chalon.bertin.fr>
- In-Reply-To
- <20110225133056.GA1026@sigill.intra.peff.net>
That's a nice feature.
It may be good to extend the idea to support editing non-default notes refs too. Maybe something like:
<commit msg> --- Notes --- <info for GIT_NOTES_REF> --- Notes <whatever> --- <info for notes/whatever>
In this case, if we want to allow the user to customize the mark, we will want to allow formatting like "--- Notes %N ---", but then the defaulting for GIT_NOTES_REF would not fit - would we want to force the use of "--- Notes commits ---" or similar ? Maybe this would warrant a separate mark for this default case:
--default-note-mark="---" --note-mark="--- %N ---"
OTOH, using a single --note-mark and no special case for the default notes ref seems more sane to me, since that shows the user when a non-default GIT_NOTES_REF is in effect.
We may also want it to behave in a way similar to git-log, including --show-notes[=<ref>] support to override the list of notes ref to be considered.
-- Yann Dirson - Bertin Technologies