git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC/PATCH] commit notes workflow

From
YDYann Dirson <dirson@bertin.fr>
Date
Mar 9, 2011, 08:13 UTC
Message-ID
<20110309091307.4b759b7e@chalon.bertin.fr>
In-Reply-To
<20110225133056.GA1026@sigill.intra.peff.net>
That's a nice feature.

It may be good to extend the idea to support editing non-default notes refs too. Maybe something like:

<commit msg> --- Notes --- <info for GIT_NOTES_REF> --- Notes <whatever> --- <info for notes/whatever>

In this case, if we want to allow the user to customize the mark, we will want to allow formatting like "--- Notes %N ---", but then the defaulting for GIT_NOTES_REF would not fit - would we want to force the use of "--- Notes commits ---" or similar ? Maybe this would warrant a separate mark for this default case:

	--default-note-mark="---"
	--note-mark="--- %N ---"

OTOH, using a single --note-mark and no special case for the default notes ref seems more sane to me, since that shows the user when a non-default GIT_NOTES_REF is in effect.

We may also want it to behave in a way similar to git-log, including --show-notes[=<ref>] support to override the list of notes ref to be considered.

-- 
Yann Dirson - Bertin Technologies
Previous: Jeff King
Message 27 of 27 in “commit notes workflow”
  1. commit notes workflowJeff King, Feb 25, 2011
  2. Johan HerlandFeb 25, 2011
  3. Jeff KingMar 1, 2011
  4. Johan HerlandMar 2, 2011
  5. Sverre RabbelierMar 3, 2011
  6. Junio C HamanoMar 3, 2011
  7. Sverre RabbelierMar 3, 2011
  8. commit, status: #comment diff output in verbose modeIan Ward Comfort, Mar 3, 2011
  9. Sverre RabbelierMar 3, 2011
  10. Jeff KingMar 7, 2011
  11. 1/2 notes: make expand_notes_ref globally accessibleJeff King, Mar 7, 2011
  12. Johan HerlandMar 8, 2011
  13. 2/2 commit: allow editing notes in commit message editorJeff King, Mar 7, 2011
  14. Johan HerlandMar 8, 2011
  15. Michel LespinasseMar 8, 2011
  16. Chris PackhamMar 2, 2011
  17. Drew NorthupMar 2, 2011
  18. Piotr KrukowieckiMar 2, 2011
  19. Junio C HamanoFeb 25, 2011
  20. Drew NorthupFeb 25, 2011
  21. Jeff KingMar 1, 2011
  22. Drew NorthupMar 1, 2011
  23. Jeff KingMar 1, 2011
  24. Drew NorthupMar 1, 2011
  25. Michael J GruberFeb 27, 2011
  26. Jeff KingMar 1, 2011
  27. Yann DirsonMar 9, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.