git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC/PATCH] commit notes workflow

From
Jeff King <peff@peff.net>
Date
Mar 1, 2011, 22:00 UTC
Message-ID
<20110301220053.GB23945@sigill.intra.peff.net>
In-Reply-To
<1298665854.27129.25.camel@drew-northup.unet.maine.edu>
On Fri, Feb 25, 2011 at 03:30:54PM -0500, Drew Northup wrote:
Show 19 quoted lines
> > So your commit template looks like:
> > 
> >   subject
> > 
> >   commit message body
> >   ---
> >   notes data
> > 
> >   # usual template stuff
> > 
> > I'm curious what people think. Do others find this useful? Does it seem
> > harmful?
> > 
> 
> I'm in agreement with the others that it doesn't seem like a bad idea,
> and likely a good one. Just one thing, can you add an end-of-note
> delimiter (the same thing perhaps)? I didn't spend a long time looking
> at the code, but I can imagine more than a few ways for this to go wrong
> without one.

We could add one pretty easily, but I'm not sure what you would be delimiting it from. Can you describe a case where it would be useful?

-Peff
Previous: Drew NorthupNext: Drew Northup
Message 21 of 27 in “commit notes workflow”
  1. commit notes workflowJeff King, Feb 25, 2011
  2. Johan HerlandFeb 25, 2011
  3. Jeff KingMar 1, 2011
  4. Johan HerlandMar 2, 2011
  5. Sverre RabbelierMar 3, 2011
  6. Junio C HamanoMar 3, 2011
  7. Sverre RabbelierMar 3, 2011
  8. commit, status: #comment diff output in verbose modeIan Ward Comfort, Mar 3, 2011
  9. Sverre RabbelierMar 3, 2011
  10. Jeff KingMar 7, 2011
  11. 1/2 notes: make expand_notes_ref globally accessibleJeff King, Mar 7, 2011
  12. Johan HerlandMar 8, 2011
  13. 2/2 commit: allow editing notes in commit message editorJeff King, Mar 7, 2011
  14. Johan HerlandMar 8, 2011
  15. Michel LespinasseMar 8, 2011
  16. Chris PackhamMar 2, 2011
  17. Drew NorthupMar 2, 2011
  18. Piotr KrukowieckiMar 2, 2011
  19. Junio C HamanoFeb 25, 2011
  20. Drew NorthupFeb 25, 2011
  21. Jeff KingMar 1, 2011
  22. Drew NorthupMar 1, 2011
  23. Jeff KingMar 1, 2011
  24. Drew NorthupMar 1, 2011
  25. Michael J GruberFeb 27, 2011
  26. Jeff KingMar 1, 2011
  27. Yann DirsonMar 9, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.