git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Don't pass "--xhtml" to hightlight in gitweb.perl script.

From
ATAdam Tkac <atkac@redhat.com>
Date
Jan 27, 2011, 12:51 UTC
Message-ID
<20110127125151.GA19072@traged.englab.brq.redhat.com>
In-Reply-To
<20110127120323.GA3416@traged.englab.brq.redhat.com>

The "--xhtml" option is supported only in highlight < 3.0. There is no option to enforce (X)HTML output format compatible with both highlight < 3.0 and highlight >= 3.0. However default output format is HTML so we don't need to explicitly specify it.

Signed-off-by: Adam Tkac <atkac@redhat.com>
---
 gitweb/gitweb.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 1025c2f..0779f12 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -3468,7 +3468,7 @@ sub run_highlighter {
 	close $fd;
 	open $fd, quote_command(git_cmd(), "cat-file", "blob", $hash)." | ".
 	          quote_command($highlight_bin).
-	          " --xhtml --fragment --syntax $syntax |"
+	          " --fragment --syntax $syntax |"
 		or die_error(500, "Couldn't open file or run syntax highlighter");
 	return $fd;
 }
-- 
1.7.3.5
Previous: Adam Tkac
Message 5 of 5 in “Pass "-O xhtml" param to highlight instead of "-xhtml"”
  1. Pass "-O xhtml" param to highlight instead of "-xhtml"Adam Tkac, Jan 26, 2011
  2. Jakub NarebskiJan 26, 2011
  3. Junio C HamanoJan 26, 2011
  4. Adam TkacJan 27, 2011
  5. Don't pass "--xhtml" to hightlight in gitweb.perl script.Adam Tkac, Jan 27, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.