git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Pass "-O xhtml" param to highlight instead of "-xhtml"

From
ATAdam Tkac <atkac@redhat.com>
Date
Jan 26, 2011, 17:11 UTC
Message-ID
<20110126171118.GA867@traged.englab.brq.redhat.com>
Hello,

attached patch fixes the gitweb.perl script. Current highlight utility doesn't recognize --xhtml parameter, it recognizes only "-O xhtml" parameter.

Reference: https://bugzilla.redhat.com/show_bug.cgi?id=672293
Regards, Adam
-- 
Adam Tkac, Red Hat, Inc.


>From ec8043a730c165d8b438ccaba7c3cf5dc5fa65bc Mon Sep 17 00:00:00 2001
From: Adam Tkac <atkac@redhat.com>
Date: Wed, 26 Jan 2011 17:46:29 +0100
Subject: [PATCH] Pass "-O xhtml" parameter instead of "--xhtml" to hightlight in gitweb.

Signed-off-by: Jochen Schmitt <jochen@herr-schmitt.de>
Signed-off-by: Adam Tkac <atkac@redhat.com>
---
 gitweb/gitweb.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 1025c2f..88556f4 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -3468,7 +3468,7 @@ sub run_highlighter {
 	close $fd;
 	open $fd, quote_command(git_cmd(), "cat-file", "blob", $hash)." | ".
 	          quote_command($highlight_bin).
-	          " --xhtml --fragment --syntax $syntax |"
+	          " -O xhtml --fragment --syntax $syntax |"
 		or die_error(500, "Couldn't open file or run syntax highlighter");
 	return $fd;
 }
-- 
1.7.3.5
Next: Jakub Narebski
Message 1 of 5 in “Pass "-O xhtml" param to highlight instead of "-xhtml"”
  1. Pass "-O xhtml" param to highlight instead of "-xhtml"Adam Tkac, Jan 26, 2011
  2. Jakub NarebskiJan 26, 2011
  3. Junio C HamanoJan 26, 2011
  4. Adam TkacJan 27, 2011
  5. Don't pass "--xhtml" to hightlight in gitweb.perl script.Adam Tkac, Jan 27, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.