Re: [PATCH] Avoid unportable nested double- and backquotes in shell scripts.

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Jan 8, 2011, 16:14 UTC
Message-ID: <20110108161441.GA28898@burratino>
In-Reply-To: <20110108090105.GB14536@gmx.de>

Ralf Wildenhues wrote:

> [Subject: Avoid unportable nested double- and backquotes in shell scripts]
>
> Some shells parse them wrongly, esp. pdksh.

How does it treat $( ) command substitutions? (We use those more heavily and they are easier on the eyes anyway.)

Show 8 quoted lines

> --- a/t/t9107-git-svn-migrate.sh
> +++ b/t/t9107-git-svn-migrate.sh
> @@ -94,7 +94,7 @@ test_expect_success 'migrate --minimize on old inited layout' '
>  		echo "$svnrepo"$path > "$GIT_DIR"/svn/$ref/info/url ) || exit 1;
>  	done &&
>  	git svn migrate --minimize &&
> -	test -z "`git config -l | grep "^svn-remote\.git-svn\."`" &&
> +	! git config -l | grep "^svn-remote\.git-svn\." &&

I thought I remembered portability problems with the

	! a | b

construct but it seems I am wrong; t7810-grep.sh uses that construct without trouble, at least.