[PATCH] Avoid unportable nested double- and backquotes in shell scripts.
- From
- Ralf Wildenhues <ralf.wildenhues@gmx.de>
- Date
- Jan 8, 2011, 09:01 UTC
- Message-ID
- <20110108090105.GB14536@gmx.de>
Some shells parse them wrongly, esp. pdksh. On the other hand, the right-hand side of assignments is not word-split, so they can be used as workarounds.
Signed-off-by: Ralf Wildenhues <Ralf.Wildenhues@gmx.de> --- contrib/examples/git-fetch.sh | 2 +- t/t9107-git-svn-migrate.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/contrib/examples/git-fetch.sh b/contrib/examples/git-fetch.sh index a314273..06caf6b 100755 --- a/contrib/examples/git-fetch.sh +++ b/contrib/examples/git-fetch.sh @@ -67,7 +67,7 @@ do keep='-k -k' ;; --depth=*) - shallow_depth="--depth=`expr "z$1" : 'z-[^=]*=\(.*\)'`" + shallow_depth=--depth=`expr "z$1" : 'z-[^=]*=\(.*\)'` ;; --depth) shift diff --git a/t/t9107-git-svn-migrate.sh b/t/t9107-git-svn-migrate.sh index 289fc31..3d2ae3e 100755 --- a/t/t9107-git-svn-migrate.sh +++ b/t/t9107-git-svn-migrate.sh @@ -94,7 +94,7 @@ test_expect_success 'migrate --minimize on old inited layout' ' echo "$svnrepo"$path > "$GIT_DIR"/svn/$ref/info/url ) || exit 1; done && git svn migrate --minimize && - test -z "`git config -l | grep "^svn-remote\.git-svn\."`" && + ! git config -l | grep "^svn-remote\.git-svn\." && git config --get-all svn-remote.svn.fetch > fetch.out && grep "^trunk:refs/remotes/trunk$" fetch.out && grep "^branches/a:refs/remotes/a$" fetch.out &&
-- 1.7.4.rc1