git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 4/4] vcs-svn: improve reporting of input errors

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Jan 4, 2011, 10:16 UTC
Message-ID
<20110104101605.GA24844@burratino>
In-Reply-To
<20101228105410.GD13360@burratino>
Jonathan Nieder wrote:
> --- a/vcs-svn/svndump.c
> +++ b/vcs-svn/svndump.c
> @@ -107,20 +107,37 @@ static void init_keys(void)
[...]
Show 5 quoted lines
>  		} else if (!strncmp(t, "V ", 2)) {
>  			len = atoi(&t[2]);
>  			val = buffer_read_string(len);
> +			if (!t)
> +				die_short_read();
This should have said "if (!val)".  Sorry for the confusion.
Previous: Jonathan Nieder
Message 6 of 6 in “improving svn-fe error handling”
  1. 0/4 improving svn-fe error handlingJonathan Nieder, Dec 28, 2010
  2. 1/4 vcs-svn: allow input errors to be detected promptlyJonathan Nieder, Dec 28, 2010
  3. 2/4 vcs-svn: make buffer_skip_bytes return length readJonathan Nieder, Dec 28, 2010
  4. 3/4 vcs-svn: make buffer_copy_bytes return length readJonathan Nieder, Dec 28, 2010
  5. 4/4 vcs-svn: improve reporting of input errorsJonathan Nieder, Dec 28, 2010
  6. Jonathan NiederJan 4, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.