From: Jonathan Nieder Date: Tue, 04 Jan 2011 10:16:05 GMT Subject: Re: [PATCH 4/4] vcs-svn: improve reporting of input errors Message-ID: <20110104101605.GA24844@burratino> In-Reply-To: <20101228105410.GD13360@burratino> Jonathan Nieder wrote: > --- a/vcs-svn/svndump.c > +++ b/vcs-svn/svndump.c > @@ -107,20 +107,37 @@ static void init_keys(void) [...] > } else if (!strncmp(t, "V ", 2)) { > len = atoi(&t[2]); > val = buffer_read_string(len); > + if (!t) > + die_short_read(); This should have said "if (!val)". Sorry for the confusion.