git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/3] config: add git_config_from_sha1() to read from a blob

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Dec 9, 2010, 17:02 UTC
Message-ID
<20101209170228.GC5974@burratino>
In-Reply-To
<AANLkTi=qt-uwXdUquRAv_1VpMUQuUR+aNMuxSHdpMhXd@mail.gmail.com>
Thiago Farina wrote:
> 2010/12/9 Nguyễn Thái Ngọc Duy <pclouds@gmail.com>:
Show 5 quoted lines
>> +static int git_config_from_sha1(config_fn_t fn, const char *sha1_name, void *data)
>> +{
>
> Is worth documenting the return value of this function and what it
> does? It returns 0 on success otherwise returns -1.

If that is the return value, then no. It is the usual in git (and other C programs that follow libc conventions).

Previous: Thiago FarinaNext: Nguyễn Thái Ngọc Duy
Message 5 of 11 in “[RFC/WIP 0/3] Shared config”
  1. Nguyễn Thái Ngọc DuyDec 9, 2010
  2. 1/3 config: read full file content before parsingNguyễn Thái Ngọc Duy, Dec 9, 2010
  3. 2/3 config: add git_config_from_sha1() to read from a blobNguyễn Thái Ngọc Duy, Dec 9, 2010
  4. Thiago FarinaDec 9, 2010
  5. Jonathan NiederDec 9, 2010
  6. 3/3 config: add core.sharedconfigNguyễn Thái Ngọc Duy, Dec 9, 2010
  7. Thiago FarinaDec 9, 2010
  8. Nguyen Thai Ngoc DuyDec 10, 2010
  9. Junio C HamanoDec 9, 2010
  10. Jonathan NiederDec 9, 2010
  11. Nguyen Thai Ngoc DuyDec 10, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.