From: Jonathan Nieder <jrnieder@gmail.com>
Date: Thu, 09 Dec 2010 17:02:28 GMT
Subject: Re: [PATCH 2/3] config: add git_config_from_sha1() to read from a blob
Message-ID: <20101209170228.GC5974@burratino>
In-Reply-To: <AANLkTi=qt-uwXdUquRAv_1VpMUQuUR+aNMuxSHdpMhXd@mail.gmail.com>

Thiago Farina wrote:
> 2010/12/9 Nguyễn Thái Ngọc Duy <pclouds@gmail.com>:

>> +static int git_config_from_sha1(config_fn_t fn, const char *sha1_name, void *data)
>> +{
>
> Is worth documenting the return value of this function and what it
> does? It returns 0 on success otherwise returns -1.

If that is the return value, then no.  It is the usual in git (and
other C programs that follow libc conventions).