Re: gitweb: false base href sent when integrated via reverse proxy and path_info is active
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Nov 28, 2010, 21:10 UTC
- Message-ID
- <20101128211054.GA20203@burratino>
- In-Reply-To
- <4CF2BBEE.2050808@nachtgeist.net>
Daniel Reichelt wrote:
> However, I just tried that and it failed. $base_url gets ignored in > gitweb.conf and even setting $my_url and $my_uri in gitweb.conf seems to > have no effect at all.
Aha. The bug fixed by v1.7.3-rc0~85^2 (gitweb: allow configurations that change with each request, 2010-07-30) strikes again.
Daniel, could you try again with version 1:1.7.2.3-2.1 (from Debian sid)?
Jakub, we should probably tweak evaluate_uri to do something special if $base_url is already set, or advertise that $base_url needs to be set in per_request_config when that feature is enabled.
Thanks again. Jonathan